On Sun, Jan 5, 2020 at 2:22 PM Michael S. Tsirkin <m...@redhat.com> wrote:
> On Thu, Dec 26, 2019 at 06:36:48AM +0200, Yuri Benditovich wrote: > > https://bugzilla.redhat.com/show_bug.cgi?id=1708480 > > Fix leak of region reference that prevents complete > > device deletion on hot unplug. > > > > Signed-off-by: Yuri Benditovich <yuri.benditov...@daynix.com> > > I rebased this on top of my tree. > > Got this: > > > commit f3dee6a062c1f4445768296ee39070bab9863372 > Author: Yuri Benditovich <yuri.benditov...@daynix.com> > Date: Thu Dec 26 06:36:48 2019 +0200 > > virtio: reset region cache when on queue deletion > > https://bugzilla.redhat.com/show_bug.cgi?id=1708480 > Fix leak of region reference that prevents complete > device deletion on hot unplug. > > Signed-off-by: Yuri Benditovich <yuri.benditov...@daynix.com> > Message-Id: <20191226043649.14481-2-yuri.benditov...@daynix.com> > > diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c > index 95d8ff8508..7b861e0ca0 100644 > --- a/hw/virtio/virtio.c > +++ b/hw/virtio/virtio.c > @@ -2344,6 +2344,7 @@ void virtio_delete_queue(VirtQueue *vq) > vq->handle_aio_output = NULL; > g_free(vq->used_elems); > vq->used_elems = NULL; > + virtio_virtqueue_reset_region_cache(vq); > } > > void virtio_del_queue(VirtIODevice *vdev, int n) > > Can you confirm pls? > Yes, it is
