Patchew URL: https://patchew.org/QEMU/20200112124913.94959-1-ys...@users.sourceforge.jp/
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v28 00/22] Add RX archtecture support Type: series Message-id: 20200112124913.94959-1-ys...@users.sourceforge.jp === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Switched to a new branch 'test' 9c8993a qemu-doc.texi: Add RX section. b31e438 BootLinuxConsoleTest: Test the RX-Virt machine 94d50a2 Add rx-softmmu 5d809ac hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core cfae030 hw/rx: Honor -accel qtest 65c9f90 hw/rx: RX Target hardware definition 5cc9572 hw/char: RX62N serial communication interface (SCI) 56dc57a hw/timer: RX62N internal timer modules 4378db2 hw/intc: RX62N interrupt controller (ICUa) b692705 target/rx: Dump bytes for each insn during disassembly 32dc7d6 target/rx: Collect all bytes during disassembly 0257d0f target/rx: Emit all disassembly in one prt() 38fc5ec target/rx: Use prt_ldmi for XCHG_mr disassembly 7770d4e target/rx: Replace operand with prt_ldmi in disassembler 04f0e2e target/rx: Disassemble rx_index_addr into a string 60f3f19 target/rx: RX disassembler a5da94c target/rx: CPU definition 017772d target/rx: TCG helper 9ff83af target/rx: TCG translation 7388b99 hw/registerfields.h: Add 8bit and 16bit register macros 9c71fe7 qemu/bitops.h: Add extract8 and extract16 e31179b MAINTAINERS: Add RX === OUTPUT BEGIN === 1/22 Checking commit e31179b04884 (MAINTAINERS: Add RX) 2/22 Checking commit 9c71fe7faec8 (qemu/bitops.h: Add extract8 and extract16) 3/22 Checking commit 7388b996fcc3 (hw/registerfields.h: Add 8bit and 16bit register macros) Use of uninitialized value in concatenation (.) or string at ./scripts/checkpatch.pl line 2484. ERROR: Macros with multiple statements should be enclosed in a do - while loop #27: FILE: include/hw/registerfields.h:25: +#define REG8(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) }; ERROR: Macros with multiple statements should be enclosed in a do - while loop #31: FILE: include/hw/registerfields.h:29: +#define REG16(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) / 2 }; total: 2 errors, 0 warnings, 56 lines checked Patch 3/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/22 Checking commit 9ff83afa1af6 (target/rx: TCG translation) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #20: new file mode 100644 total: 0 errors, 1 warnings, 3065 lines checked Patch 4/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/22 Checking commit 017772d3798b (target/rx: TCG helper) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #21: new file mode 100644 total: 0 errors, 1 warnings, 650 lines checked Patch 5/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/22 Checking commit a5da94c91154 (target/rx: CPU definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #32: new file mode 100644 total: 0 errors, 1 warnings, 588 lines checked Patch 6/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/22 Checking commit 60f3f191676e (target/rx: RX disassembler) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #38: new file mode 100644 total: 0 errors, 1 warnings, 1497 lines checked Patch 7/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/22 Checking commit 04f0e2e75777 (target/rx: Disassemble rx_index_addr into a string) 9/22 Checking commit 7770d4e19c0d (target/rx: Replace operand with prt_ldmi in disassembler) 10/22 Checking commit 38fc5ec9ace5 (target/rx: Use prt_ldmi for XCHG_mr disassembly) 11/22 Checking commit 0257d0f103e0 (target/rx: Emit all disassembly in one prt()) 12/22 Checking commit 32dc7d60b331 (target/rx: Collect all bytes during disassembly) 13/22 Checking commit b692705e6235 (target/rx: Dump bytes for each insn during disassembly) 14/22 Checking commit 4378db2a66e8 (hw/intc: RX62N interrupt controller (ICUa)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #40: new file mode 100644 total: 0 errors, 1 warnings, 445 lines checked Patch 14/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 15/22 Checking commit 56dc57aa2790 (hw/timer: RX62N internal timer modules) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #50: new file mode 100644 total: 0 errors, 1 warnings, 845 lines checked Patch 15/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/22 Checking commit 5cc9572f03fe (hw/char: RX62N serial communication interface (SCI)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #43: new file mode 100644 total: 0 errors, 1 warnings, 401 lines checked Patch 16/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/22 Checking commit 65c9f907615e (hw/rx: RX Target hardware definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #29: new file mode 100644 total: 0 errors, 1 warnings, 480 lines checked Patch 17/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 18/22 Checking commit cfae030bd281 (hw/rx: Honor -accel qtest) 19/22 Checking commit 5d809acd600a (hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core) 20/22 Checking commit 94d50a285a1a (Add rx-softmmu) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #59: new file mode 100644 total: 0 errors, 1 warnings, 74 lines checked Patch 20/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 21/22 Checking commit b31e43883b74 (BootLinuxConsoleTest: Test the RX-Virt machine) 22/22 Checking commit 9c8993a0b033 (qemu-doc.texi: Add RX section.) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200112124913.94959-1-ys...@users.sourceforge.jp/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com