Excellent! I will add an option (or object property) for vhost-user-blk server oject which will tell the daemon process to exit when the client disconnects, thus "make check-qtest" will not get held by this daemon process. After that since Kevin's qemu-storage-daemon support "-object" option (https://patchew.org/QEMU/20191017130204.16131-1-kw...@redhat.com/20191017130204.16131-3-kw...@redhat.com/) and vhost-user-server is a user-creatable QOM object, it will work out of the box.
I'm curious when will be formal version of qemu-storage-daemon finished so I can take advantage of it? Or should I apply the RFC PATCHes to my working branch directly and submit them together with the patches on vhost-user-blk server feature when posting v3? On Thu, Jan 16, 2020 at 10:04 PM Stefan Hajnoczi <stefa...@redhat.com> wrote: > > On Tue, Jan 14, 2020 at 10:06:18PM +0800, Coiby Xu wrote: > > vhost-user-blk can have played as vhost-user backend but it only supports > > raw file and don't support VIRTIO_BLK_T_DISCARD and > > VIRTIO_BLK_T_WRITE_ZEROES operations on raw file (ioctl(fd, BLKDISCARD) is > > only valid for real block device). > > > > Signed-off-by: Coiby Xu <coiby...@gmail.com> > > --- > > qemu-vu.c | 264 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 264 insertions(+) > > create mode 100644 qemu-vu.c > > Kevin has been working on qemu-storage-daemon, a tool for running NBD > exports, block jobs, and other storage features that are not part of a > guest. I think qemu-storage-daemon would be the appropriate tool for > running vhost-user-blk servers. A dedicated binary is not necessary. > > Stefan -- Best regards, Coiby
