On Tue, Jan 14, 2020 at 2:56 AM Alex Bennée <alex.ben...@linaro.org> wrote: > Could we cut out the middle-man and just qemu_add_log(LOG_STRACE) here > and drop the enable_strace variable.
This code has been re-factored based on Laurent's comments. In v2 `enable_strace` is still needed to avoid QEMU_LOG/-d overwriting the mask set by -strace. > Please don't drop the brace - c.f. CODING_STYLE.rst Thanks for the catch! > Side note, print_taken_signal might want to consider using the > qemu_log_lock() functionality to keep sequential qemu_log's together. I > suspect you might want to do the same for syscalls. This is likely true, but outside the scope of this patch (this patch preserves the current bad behavior). When I get some spare time I'll try and address this in a follow up patch series.
