On 1/20/20 1:48 AM, Alex Bennée wrote:
>> + default:
>> + sigsegv:
>
> this label looks a little extraneous.
>
> Otherwise:
>
> Reviewed-by: Alex Bennée <[email protected]>
>
Look a little further down:
> + default:
> + sigsegv:
> + /* Like force_sig(SIGSEGV). */
> + gen_signal(env, TARGET_SIGSEGV, TARGET_SI_KERNEL, 0);
> + return;
> + }
> +
> + /*
> + * Validate the return address.
> + * Note that the kernel treats this the same as an invalid entry point.
> + */
> + if (get_user_u64(caller, env->regs[R_ESP])) {
> + goto sigsegv;
> + }
r~
