On Tue, 21 Jan 2020 at 15:11, Marc-André Lureau <marcandre.lur...@gmail.com> wrote: > There are plenty of refactoring to do. The problem when touching the > whole code-base, imho, is review time. It may take a couple of > hours/days to come up with a cocci/spatch, and make various patches > here and there. But it takes often weeks and a lot of constant push to > various folks to get all the reviews (as seens by the qdev prop-ptr > series earlier for example). How can we better address whole code-base > changes?
It depends. If it's literally just a cocci/spatch mechanical transformation, I think we should be OK with reviewing that transform and then applying it; we don't need to get acks from every submaintainer for that kind of thing. The prop-ptr series was harder work because it required making active non-mechanical changes to various devices, which means the specific changes needed review. PS: thanks for pushing that prop-ptr work through and especially the serial device part which was both awkward and definitely needed. thanks -- PMM
