On Wed, Jun 8, 2011 at 9:55 PM, Andreas Färber <andreas.faer...@web.de> wrote: > Hey, > > I've refined the series to track the state in ISADevice and to expose it as > VMState. > Error handling has been improved, and setting the state multiple times is > no-op now. > > To read the state, I'm introducing support for bool qdev properties. > Some more qdev_prop_get_*() helpers are introduced, too. > > Still need to do some runtime testing, but I'd like to hear if this is getting > mergeable now, especially wrt VMState. > > Andreas > > > Andreas Färber (11): > qdev: Add support for property type bool > qdev: Add helpers for reading properties > isa: Provide set_state callback > isa: Allow to un-assign I/O ports > isa: Allow to un-associate an IRQ
I like the patches above. But I think the set_state() interface could be improved. For example, cpu_register_io_memory() gives an index which is passed to sysbus_register_mmio(). Then the board can instantiate the device at desired location without caring about the device internals. With set_state(), the device does everything. > parallel: Implement ISA set_state callback > serial: Implement ISA set_state() callback > fdc: Implement ISA set_state() callback > ide: Allow to discard I/O ports > ide: Implement ISA set_state() callback > prep: Add pc87312 Super I/O emulation > > Hervé Poussineau (1): > fdc: Parametrize ISA base, IRQ and DMA > > Makefile.objs | 1 + > default-configs/ppc-softmmu.mak | 2 + > hw/fdc.c | 62 ++++-- > hw/hw.h | 15 ++ > hw/ide/core.c | 8 + > hw/ide/internal.h | 1 + > hw/ide/isa.c | 32 +++- > hw/isa-bus.c | 57 +++++ > hw/isa.h | 6 + > hw/parallel.c | 69 ++++-- > hw/pc87312.c | 470 > +++++++++++++++++++++++++++++++++++++++ > hw/qdev-properties.c | 88 ++++++++ > hw/qdev.h | 13 + > hw/serial.c | 30 ++- > 14 files changed, 803 insertions(+), 51 deletions(-) > create mode 100644 hw/pc87312.c > > -- > 1.7.5.3 > > >