On 2/1/20 8:21 PM, Niek Linnenbank wrote: > Hi Philippe, > > I just got back from traveling and will start processing these and the > other comments soon. > > On Sun, Jan 19, 2020 at 7:01 PM Philippe Mathieu-Daudé > <phi...@redhat.com <mailto:phi...@redhat.com>> wrote: > > On 1/19/20 1:50 AM, Niek Linnenbank wrote: > > The Allwinner H3 is a System on Chip containing four ARM Cortex A7 > > processor cores. Features and specifications include DDR2/DDR3 memory, > > SD/MMC storage cards, 10/100/1000Mbit Ethernet, USB 2.0, HDMI and > > various I/O modules. This commit adds support for the Allwinner H3 > > System on Chip. > > > > Signed-off-by: Niek Linnenbank <nieklinnenb...@gmail.com > <mailto:nieklinnenb...@gmail.com>> > > --- [...] > > diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig > > index 3d86691ae0..bb75c1de17 100644 > > --- a/hw/arm/Kconfig > > +++ b/hw/arm/Kconfig > > @@ -295,6 +295,14 @@ config ALLWINNER_A10 > > select SERIAL > > select UNIMP > > > > +config ALLWINNER_H3 > > + bool > > + select ALLWINNER_A10_PIT > > We should now rename this as ALLWINNER_PIT. > > > I see your point, now both SoCs are using the A10 specific PIT timer. > Previously we agreed to do the generalization of that timer in a > separate patch series. > I think it makes sense to also do the rename of this item as part of > that separate series.
Fine by me.
