On 2/6/20 1:40 PM, Andrew Jones wrote:
On Thu, Feb 06, 2020 at 01:08:53PM +0100, Philippe Mathieu-Daudé wrote:
...
+/* KVM VCPU properties should be prefixed with "kvm-". */
+void kvm_arm_add_vcpu_properties(Object *obj)
+{
+ if (!kvm_enabled()) {
This can't happen, right? Can we turn that into an assertion, or
remove the check?
You're right. An assert would be more appropriate. Will you send a patch?
Apparently this can be called with KVM_CONFIG && !kvm_enabled():
See kvm_arm_set_cpu_features_from_host()
{
if (!arm_host_cpu_features.dtb_compatible) {
if (!kvm_enabled() ||
!kvm_arm_get_host_cpu_features(&arm_host_cpu_features)) {
/* We can't report this error yet, so flag that we need to
* in arm_cpu_realizefn().
*/
I won't modify your patch (until I have a better understanding of
TYPE_ARM_HOST_CPU).
