On Wed, 12 Feb 2020 at 14:28, Daniel P. Berrangé <berra...@redhat.com> wrote: > > On Wed, Feb 12, 2020 at 02:18:19PM +0000, Peter Maydell wrote: > > On Wed, 12 Feb 2020 at 13:16, Miroslav Rezanina <mreza...@redhat.com> wrote: > > > > > > Patch 6a7e2bbee5 docs: add virtiofsd(1) man page introduced new man > > > page virtiofsd.1. Unfortunately, wrong file location is used as > > > source for install command. This cause installation of docs fail. > > > > > > Fixing wrong location so installation is successful. > > > > > > Signed-off-by: Miroslav Rezanina <mreza...@redhat.com> > > > > Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> > > > > I noticed this in review of v1 of the patch > > https://patchew.org/QEMU/20200127162514.56784-1-stefa...@redhat.com/ > > but missed that it hadn't been fixed in v2/v3. > > How come the mistake didn't break any of our CI ? Looks like it > should have failed due to non-existing source file
I imagine all our CI setups use separate-build-dir and don't test 'make install'. This only shows up if you do build-in-source-tree and then 'make install'. (In a separate-build-dir setup, the MANUAL_BUILDDIR is the same as the actual build dir, which is the same as make's current working directory, so forgetting it in the install rune doesn't matter. In a build from the source tree, Sphinx requires the output to be to a different directory than the source, so we have to create a subdirectory to be the MANUAL_BUILDDIR.) thanks -- PMM