> -----Original Message----- > From: Philippe Mathieu-Daudé <phi...@redhat.com> > Sent: Tuesday, February 11, 2020 1:41 AM > To: Taylor Simpson <tsimp...@quicinc.com>; qemu-devel@nongnu.org > Cc: richard.hender...@linaro.org; laur...@vivier.eu; riku.voi...@iki.fi; > aleksandar.m.m...@gmail.com > Subject: Re: [RFC PATCH 29/66] Hexagon opcode data structures > > > +#ifndef OPCODES_H > > HEXAGON_OPCODES_H > > I wonder if it would ease review to split this patch in 2, keep the C > here, but provide opcodes.h in an earlier patch.
Wouldn't using scripts/git.orderfile solve this just as well? It will put opcodes.h ahead of opcodes.c in this patch. > > > +#define OPCODES_H > > +