On 2/12/20 2:45 AM, Alex Bennée wrote: > > Richard Henderson <richard.hender...@linaro.org> writes: > >> On 1/30/20 1:38 PM, Stefan Hajnoczi wrote: >>> From: Salvador Fandino <salva...@qindel.com> >>> >>> NULL is a valid log filename used to indicate we want to use stderr >>> but qemu_set_log_filename (which is called by bsd-user/main.c) was not >>> handling it correctly. >>> >>> That also made redundant a couple of NULL checks in calling code which >>> have been removed. >>> >>> Signed-off-by: Salvador Fandino <salva...@qindel.com> >>> Message-Id: <20200123193626.19956-1-salva...@qindel.com> >>> Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com> >>> --- >>> trace/control.c | 4 +--- >>> util/log.c | 28 ++++++++++++++++------------ >>> vl.c | 5 +---- >>> 3 files changed, 18 insertions(+), 19 deletions(-) >> >> This patch has broken -D <filename> for *-linux-user. >> After e144a605a, all logging goes to stderr. > > I posted: > > Subject: [PATCH] tracing: only allow -trace to override -D if set > Date: Tue, 11 Feb 2020 11:10:54 +0000 > Message-Id: <20200211111054.27538-1-alex.ben...@linaro.org> > > as a fix which partially reverted this.
Thanks, that fixes it for me. r~
