On Thu, 13 Feb 2020 at 16:33, Philippe Mathieu-Daudé <phi...@redhat.com> wrote: > > * unrealize() must clean up everything realize() creates. > > Hmm I guess remember someone once said "only for hot-pluggable objects, > else don't bother". But then we make a non-hot-pluggable object as > hot-pluggable and have to fix leaks. Or we start a new hot-pluggable > device based on some code without unrealize()...
Yeah. Almost all our devices are not hot-pluggable and don't have unrealize code. Better to just have them stay that way, or to add untested unreachable code in an unrealize method? Dunno. thanks -- PMM