"Dr. David Alan Gilbert" <dgilb...@redhat.com> wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> Signed-off-by: Juan Quintela <quint...@redhat.com> >> --- >> hw/core/qdev-properties.c | 2 +- >> migration/Makefile.objs | 1 + >> migration/migration.c | 9 + >> migration/migration.h | 1 + >> migration/multifd-zlib.c | 325 +++++++++++++++++++++++++++++++++++ >> migration/multifd.c | 6 + >> migration/multifd.h | 4 + >> qapi/migration.json | 3 +- >> tests/qtest/migration-test.c | 6 + >> 9 files changed, 355 insertions(+), 2 deletions(-) >> create mode 100644 migration/multifd-zlib.c > > Coupld of really minor points below to fix up, but other than those: > > > Reviewed-by: Dr. David Alan Gilbert <dgilb...@redhat.com> > >> } >> >> +int migrate_multifd_zlib_level(void) >> +{ >> + MigrationState *s; >> + >> + s = migrate_get_current(); >> + >> + return s->parameters.multifd_zlib_level; >> +} >> + > > Does this belong in the previous patch?
It is used only here. Should not make any difference. Anyways, changing it. > >> int migrate_use_xbzrle(void) >> { >> MigrationState *s; >> diff --git a/migration/migration.h b/migration/migration.h >> index 3d23a0852e..95e9c196ff 100644 >> --- a/migration/migration.h >> +++ b/migration/migration.h >> @@ -301,6 +301,7 @@ bool migrate_use_multifd(void); >> bool migrate_pause_before_switchover(void); >> int migrate_multifd_channels(void); >> MultiFDMethod migrate_multifd_method(void); >> +int migrate_multifd_zlib_level(void); >> + int flush = Z_NO_FLUSH; >> + unsigned long start = zs->total_out; >> + >> + if (i == used - 1) { > > Note an extra space there. > Fixed, thanks.