On Fri, 14 Feb 2020 at 15:46, Markus Armbruster <arm...@redhat.com> wrote: > > Peter Maydell <peter.mayd...@linaro.org> writes: > > > On Fri, 14 Feb 2020 at 14:23, Markus Armbruster <arm...@redhat.com> wrote: > >> What's the rationale for the split between > >> > >> [PATCH v2 13/30] qapi/block-core.json: Use explicit bulleted lists > >> [PATCH v2 14/30] qapi/ui.json: Use explicit bulleted lists > >> [PATCH v2 15/30] qapi/{block, misc, tmp, net}.json: Use explicit > >> bulleted lists > >> > >> ? > > > > Just keeping down the size of individual patches for ease of > > review. ui.json and block-core.json both had enough uses that > > needed fixing to feel like reasonably patch-sized amounts. This > > patch is all the straggler files, none of which had numerous > > enough changes to seem worth splitting further. > > I see. > > Separating block.json and block-core.json is a bit odd. > > Mind if I squash all three?
I don't mind; the split was as I say mostly just to keep commit sizes down, so if all-squashed-together works better for you as a reviewer feel free. thanks -- PMM