On Tue, Feb 18, 2020 at 12:18:04PM -0500, Laine Stump wrote: > On 2/18/20 11:17 AM, Julia Suvorova wrote: > > Make hot-plug/hot-unplug on PCIe Root Ports optional to allow libvirt > > to manage it and restrict unplug for the entire machine. This is going > > to prevent user-initiated unplug in guests (Windows mostly). > > Usage: > > -device pcie-root-port,disable-hotplug=true,... > > Double negatives (e.g. "disable-hotplug=false") tend to confuse simple minds > like mine. Would it be any more difficult to make the name of the option > positive instead (e.g. "enable-hotplug") with the default set to "true"?
Or simply "hotpluggable=on|off" Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|