Am 26.02.2020 um 09:46 hat kuhn.chen...@huawei.com geschrieben:
> From: Chen Qun <kuhn.chen...@huawei.com>
>
> Clang static code analyzer show warning:
> block/iscsi.c:1920:9: warning: Value stored to 'flags' is never read
> flags &= ~BDRV_O_RDWR;
> ^ ~~~~~~~~~~~~
>
> Reported-by: Euler Robot <euler.ro...@huawei.com>
> Signed-off-by: Chen Qun <kuhn.chen...@huawei.com>
Hmm, I'm not so sure about this one because if we remove the line, flags
will be inconsistent with bs->open_flags. It feels like setting a trap
for anyone who wants to add code using flags in the future.
Kevin
> Cc: Ronnie Sahlberg <ronniesahlb...@gmail.com>
> Cc: Paolo Bonzini <pbonz...@redhat.com>
> Cc: Peter Lieven <p...@kamp.de>
> Cc: Kevin Wolf <kw...@redhat.com>
> Cc: Max Reitz <mre...@redhat.com>
> ---
> block/iscsi.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/block/iscsi.c b/block/iscsi.c
> index 682abd8e09..ed88479ede 100644
> --- a/block/iscsi.c
> +++ b/block/iscsi.c
> @@ -1917,7 +1917,6 @@ static int iscsi_open(BlockDriverState *bs, QDict
> *options, int flags,
> if (ret < 0) {
> goto out;
> }
> - flags &= ~BDRV_O_RDWR;
> }
>
> iscsi_readcapacity_sync(iscsilun, &local_err);
> --
> 2.23.0
>
>
