Philippe Mathieu-Daudé <phi...@redhat.com> writes: > On 2/28/20 10:50 AM, Philippe Mathieu-Daudé wrote: [...] >> Thanks for your review. I'll drop the changes in util/oslib-win32.c >> for for now, and add a note in my TODO for after the 5.0 release. > > Well if I follow this line, I'v to drop the changes in util/osdep.c too. > Maybe we can keep fprintf() for now and improve the error message, and > do the fprintf -> error_report cleanup later?
I recommend to convert from fprintf() to error_report() & friends and improve the message all in one go. Separating different kinds of changes makes sense when some kinds are mechanical and the resulting mechanical patches are large. These patches aren't large. But it's really up to you. I'm not going to veto an improvement only because further improvement is called for.