On Thu, Jun 23, 2011 at 12:22 AM, Andreas Färber <andreas.faer...@web.de> wrote: > Am 20.06.2011 um 15:11 schrieb Avi Kivity: > >> On 06/20/2011 03:33 PM, Jan Kiszka wrote: >>> >>> > --- a/hw/vga.c >>> > +++ b/hw/vga.c >>> > @@ -2349,15 +2349,19 @@ int ppm_save(const char *filename, struct >>> > DisplaySurface *ds) >> >>> Unrelated to this patch, but why is this function located in vga.c and >>> not in console.c? >> >> It's located in omap_lcdc.c as well. But it needs to be fully >> generalized to be moved out (handle all PixelFormats). > > For the record, there's a similar function in tcx.c as well, and I have one > coming in ibm8514.c.
The screen dumpers generate their output based on the current state of the graphics card and the VRAM, this is why they are device specific. A generic screen dumper (if possible) would read the data from display surface. Maybe this should be done at the SDL/VNC/Spice/curses/dummy level, but the output shouldn't change depending on the back end in question.
