Hi
On Sat, Mar 7, 2020 at 3:53 AM Pan Nengyuan <pannengy...@huawei.com> wrote:
>
> Fix a memory leak in qdev_get_gpio_out_connector().
>
> Reported-by: Euler Robot <euler.ro...@huawei.com>
> Signed-off-by: Pan Nengyuan <pannengy...@huawei.com>
good catch,
Reviewed-by: Marc-André Lureau <marcandre.lur...@redhat.com>
> ---
> hw/core/qdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/core/qdev.c b/hw/core/qdev.c
> index 3937d1eb1a..85f062def7 100644
> --- a/hw/core/qdev.c
> +++ b/hw/core/qdev.c
> @@ -557,7 +557,7 @@ void qdev_connect_gpio_out_named(DeviceState *dev, const
> char *name, int n,
>
> qemu_irq qdev_get_gpio_out_connector(DeviceState *dev, const char *name, int
> n)
> {
> - char *propname = g_strdup_printf("%s[%d]",
> + g_autofree char *propname = g_strdup_printf("%s[%d]",
> name ? name : "unnamed-gpio-out", n);
>
> qemu_irq ret = (qemu_irq)object_property_get_link(OBJECT(dev), propname,
> --
> 2.18.2
>
>
--
Marc-André Lureau
