On Wed, 11 Mar 2020 09:02:58 -0500 Babu Moger <babu.mo...@amd.com> wrote:
> On 3/11/20 6:39 AM, Igor Mammedov wrote: > > On Tue, 10 Mar 2020 21:33:25 -0500 > > Babu Moger <babu.mo...@amd.com> wrote: > > > >> This is an effort to re-arrange few data structure for better readability. > >> > >> 1. Add X86CPUTopoInfo which will have all the topology informations > >> required to build the cpu topology. There is no functional changes. > >> > >> 2. Introduce init_topo_info to initialize X86CPUTopoInfo members from > >> X86MachineState. > >> > >> 3. Update x86 unit tests for new calling convention with parameter > >> X86CPUTopoInfo > >> > >> There is no functional changes. > > > > patch doesn't apply to current master, so I can't really test it > > I generated the patches on top of Eduardo's tree. > > It should work if you apply after this patch. > > https://lore.kernel.org/qemu-devel/158326541877.40452.17535023236841538507.st...@naples-babu.amd.com/ thanks it helps other than minor nit patch looks fine to me, so Acked-by: Igor Mammedov <imamm...@redhat.com> > Do you want me to generate on top of master ? no need, if series is not based on master we usually put in the cover letter a link to the tree and branch series depends on > > >> > >> Signed-off-by: Babu Moger <babu.mo...@amd.com> > >> --- > >> hw/i386/pc.c | 12 ++++++------ > >> hw/i386/x86.c | 32 ++++++++++++++++++++++++-------- > >> include/hw/i386/topology.h | 38 ++++++++++++++++++++++++-------------- > >> include/hw/i386/x86.h | 3 +++ > >> tests/test-x86-cpuid.c | 43 > >> ++++++++++++++++++++++++------------------- > >> 5 files changed, 81 insertions(+), 47 deletions(-) > >> > > [...] > >> diff --git a/hw/i386/x86.c b/hw/i386/x86.c > >> index 322fb6abbc..03b8962c98 100644 > >> --- a/hw/i386/x86.c > >> +++ b/hw/i386/x86.c > >> @@ -57,6 +57,16 @@ > >> /* Physical Address of PVH entry point read from kernel ELF NOTE */ > >> static size_t pvh_start_addr; > >> > >> +inline void init_topo_info(X86CPUTopoInfo *topo_info, > >> + const X86MachineState *x86ms) > > > > not aligned properly > > Will fix it. > > > > > [...] > > >