On Tue, 17 Mar 2020 00:26:10 +1000
Nicholas Piggin <npig...@gmail.com> wrote:
> There should no longer be a reason to prevent TCG providing FWNMI.
> System Reset interrupts are generated to the guest with nmi monitor
> command and H_SIGNAL_SYS_RESET. Machine Checks can not be injected
> currently, but this could be implemented with the mce monitor cmd
> similarly to i386.
>
> Signed-off-by: Nicholas Piggin <npig...@gmail.com>
> ---
> hw/ppc/spapr_caps.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/hw/ppc/spapr_caps.c b/hw/ppc/spapr_caps.c
> index f626d769a0..679ae7959f 100644
> --- a/hw/ppc/spapr_caps.c
> +++ b/hw/ppc/spapr_caps.c
> @@ -516,10 +516,7 @@ static void cap_fwnmi_apply(SpaprMachineState *spapr,
> uint8_t val,
> return; /* Disabled by default */
> }
>
> - if (tcg_enabled()) {
> - warn_report("Firmware Assisted Non-Maskable Interrupts(FWNMI) not "
> - "supported in TCG");
With this warning removed, we can now drop the "cap-fwnmi=off" setting
in qtest, but this can be done as a followup.
Reviewed-by: Greg Kurz <gr...@kaod.org>
> - } else if (kvm_enabled()) {
> + if (kvm_enabled()) {
> if (kvmppc_set_fwnmi() < 0) {
> error_setg(errp, "Firmware Assisted Non-Maskable
> Interrupts(FWNMI) "
> "not supported by KVM");
