Patchew URL: https://patchew.org/QEMU/20200316161550.336150-1-laur...@vivier.eu/
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PULL 00/38] Linux user for 5.0 patches Message-id: 20200316161550.336150-1-laur...@vivier.eu Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Switched to a new branch 'test' fee33bd linux-user, openrisc: sync syscall numbers with kernel v5.5 fd2f311 linux-user, nios2: sync syscall numbers with kernel v5.5 6a5d29c linux-user, aarch64: sync syscall numbers with kernel v5.5 0f61c49 scripts: add a script to generate syscall_nr.h ba74d13 linux-user,mips: update syscall-args-o32.c.inc 6093ee8 linux-user,mips: move content of mips_syscall_args 329d3cf linux-user: update syscall.tbl from linux 0bf999f9c5e7 fdd68d1 linux-user, scripts: add a script to update syscall.tbl 39929e8 linux-user, mips64: add syscall table generation support cd6dd35 linux-user, mips: add syscall table generation support 890ff9d linux-user, x86_64: add syscall table generation support 353fb76 linux-user, i386: add syscall table generation support 9db49be linux-user, x86_64, i386: cleanup TARGET_NR_arch_prctl 9da00a8 linux-user, sparc, sparc64: add syscall table generation support e7dfa49 linux-user, s390x: add syscall table generation support 07108d6 linux-user, s390x: remove syscall definitions for !TARGET_S390X 0a1acf7 linux-user, ppc: add syscall table generation support 48126a9 linux-user, arm: add syscall table generation support 13a5cdd linux-user, microblaze: add syscall table generation support ea958ad linux-user, sh4: add syscall table generation support 2599c73 linux-user, xtensa: add syscall table generation support 9764b87 linux-user, m68k: add syscall table generation support 52d7b45 linux-user, hppa: add syscall table generation support baeb698 linux-user, alpha: add syscall table generation support b3d6a3d linux-user: introduce parameters to generate syscall_nr.h c4be834 linux-user/riscv: Update the syscall_nr's to the 5.5 kernel e9992a7 linux-user: Support futex_time64 022b88e linux-user/syscall: Add support for clock_gettime64/clock_settime64 0bf2c2d linux-user: Protect more syscalls fc4fcbe linux-user: Update TASK_UNMAPPED_BASE for aarch64 0e97ba7 linux-user: fix socket() strace 99fda14 linux-user: do prlimit selectively 8eb735a linux-user: Add AT_EXECFN auxval 571a225 linux-user: Flush out implementation of gettimeofday 092c4cc linux-user: Add x86_64 vsyscall page to /proc/self/maps d1a6687 linux-user/i386: Emulate x86_64 vsyscalls 169e4fb linux-user/i386: Split out gen_signal dfc6a82 target/i386: Renumber EXCP_SYSCALL === OUTPUT BEGIN === 1/38 Checking commit dfc6a82f8f0a (target/i386: Renumber EXCP_SYSCALL) 2/38 Checking commit 169e4fb16716 (linux-user/i386: Split out gen_signal) 3/38 Checking commit d1a668759f5b (linux-user/i386: Emulate x86_64 vsyscalls) 4/38 Checking commit 092c4ccea82d (linux-user: Add x86_64 vsyscall page to /proc/self/maps) 5/38 Checking commit 571a225e5502 (linux-user: Flush out implementation of gettimeofday) 6/38 Checking commit 8eb735a75f6a (linux-user: Add AT_EXECFN auxval) 7/38 Checking commit 99fda143c672 (linux-user: do prlimit selectively) 8/38 Checking commit 0e97ba7c8e8e (linux-user: fix socket() strace) 9/38 Checking commit fc4fcbe8aae4 (linux-user: Update TASK_UNMAPPED_BASE for aarch64) 10/38 Checking commit 0bf2c2d4158a (linux-user: Protect more syscalls) 11/38 Checking commit 022b88e1c6bd (linux-user/syscall: Add support for clock_gettime64/clock_settime64) 12/38 Checking commit e9992a7e4a00 (linux-user: Support futex_time64) WARNING: architecture specific defines should be avoided #26: FILE: linux-user/syscall.c:248: +#if defined(__NR_futex) WARNING: architecture specific defines should be avoided #29: FILE: linux-user/syscall.c:251: +#if defined(__NR_futex_time64) WARNING: architecture specific defines should be avoided #40: FILE: linux-user/syscall.c:303: +#if (defined(TARGET_NR_futex) && defined(__NR_futex)) || \ WARNING: architecture specific defines should be avoided #46: FILE: linux-user/syscall.c:309: +#if (defined(TARGET_NR_futex_time64) && defined(__NR_futex_teim64)) ERROR: space required after that ',' (ctx:VxV) #47: FILE: linux-user/syscall.c:310: +_syscall6(int,sys_futex_time64,int *,uaddr,int,op,int,val, ^ ERROR: space required after that ',' (ctx:VxV) #47: FILE: linux-user/syscall.c:310: +_syscall6(int,sys_futex_time64,int *,uaddr,int,op,int,val, ^ ERROR: space required after that ',' (ctx:OxV) #47: FILE: linux-user/syscall.c:310: +_syscall6(int,sys_futex_time64,int *,uaddr,int,op,int,val, ^ ERROR: space required after that ',' (ctx:VxV) #47: FILE: linux-user/syscall.c:310: +_syscall6(int,sys_futex_time64,int *,uaddr,int,op,int,val, ^ ERROR: space required after that ',' (ctx:VxV) #47: FILE: linux-user/syscall.c:310: +_syscall6(int,sys_futex_time64,int *,uaddr,int,op,int,val, ^ ERROR: space required after that ',' (ctx:VxV) #47: FILE: linux-user/syscall.c:310: +_syscall6(int,sys_futex_time64,int *,uaddr,int,op,int,val, ^ ERROR: space required after that ',' (ctx:VxV) #47: FILE: linux-user/syscall.c:310: +_syscall6(int,sys_futex_time64,int *,uaddr,int,op,int,val, ^ ERROR: space required after that ',' (ctx:OxV) #48: FILE: linux-user/syscall.c:311: + const struct timespec *,timeout,int *,uaddr2,int,val3) ^ ERROR: space required after that ',' (ctx:VxV) #48: FILE: linux-user/syscall.c:311: + const struct timespec *,timeout,int *,uaddr2,int,val3) ^ ERROR: space required after that ',' (ctx:OxV) #48: FILE: linux-user/syscall.c:311: + const struct timespec *,timeout,int *,uaddr2,int,val3) ^ ERROR: space required after that ',' (ctx:VxV) #48: FILE: linux-user/syscall.c:311: + const struct timespec *,timeout,int *,uaddr2,int,val3) ^ ERROR: space required after that ',' (ctx:VxV) #48: FILE: linux-user/syscall.c:311: + const struct timespec *,timeout,int *,uaddr2,int,val3) ^ WARNING: architecture specific defines should be avoided #58: FILE: linux-user/syscall.c:776: +#if defined(__NR_futex) WARNING: architecture specific defines should be avoided #62: FILE: linux-user/syscall.c:780: +#if defined(__NR_futex_time64) ERROR: space required after that ',' (ctx:VxV) #63: FILE: linux-user/syscall.c:781: +safe_syscall6(int,futex_time64,int *,uaddr,int,op,int,val, \ ^ ERROR: space required after that ',' (ctx:VxV) #63: FILE: linux-user/syscall.c:781: +safe_syscall6(int,futex_time64,int *,uaddr,int,op,int,val, \ ^ ERROR: space required after that ',' (ctx:OxV) #63: FILE: linux-user/syscall.c:781: +safe_syscall6(int,futex_time64,int *,uaddr,int,op,int,val, \ ^ ERROR: space required after that ',' (ctx:VxV) #63: FILE: linux-user/syscall.c:781: +safe_syscall6(int,futex_time64,int *,uaddr,int,op,int,val, \ ^ ERROR: space required after that ',' (ctx:VxV) #63: FILE: linux-user/syscall.c:781: +safe_syscall6(int,futex_time64,int *,uaddr,int,op,int,val, \ ^ ERROR: space required after that ',' (ctx:VxV) #63: FILE: linux-user/syscall.c:781: +safe_syscall6(int,futex_time64,int *,uaddr,int,op,int,val, \ ^ ERROR: space required after that ',' (ctx:VxV) #63: FILE: linux-user/syscall.c:781: +safe_syscall6(int,futex_time64,int *,uaddr,int,op,int,val, \ ^ ERROR: space required after that ',' (ctx:OxV) #64: FILE: linux-user/syscall.c:782: + const struct timespec *,timeout,int *,uaddr2,int,val3) ^ ERROR: space required after that ',' (ctx:VxV) #64: FILE: linux-user/syscall.c:782: + const struct timespec *,timeout,int *,uaddr2,int,val3) ^ ERROR: space required after that ',' (ctx:OxV) #64: FILE: linux-user/syscall.c:782: + const struct timespec *,timeout,int *,uaddr2,int,val3) ^ ERROR: space required after that ',' (ctx:VxV) #64: FILE: linux-user/syscall.c:782: + const struct timespec *,timeout,int *,uaddr2,int,val3) ^ ERROR: space required after that ',' (ctx:VxV) #64: FILE: linux-user/syscall.c:782: + const struct timespec *,timeout,int *,uaddr2,int,val3) ^ WARNING: architecture specific defines should be avoided #87: FILE: linux-user/syscall.c:6930: +#if defined(__NR_futex) WARNING: architecture specific defines should be avoided #93: FILE: linux-user/syscall.c:6936: +#if defined(__NR_futex_time64) WARNING: architecture specific defines should be avoided #99: FILE: linux-user/syscall.c:6942: +#if defined(__NR_futex) WARNING: architecture specific defines should be avoided #112: FILE: linux-user/syscall.c:6955: +#if defined(__NR_futex) WARNING: architecture specific defines should be avoided #117: FILE: linux-user/syscall.c:6960: +#if defined(__NR_futex_time64) WARNING: architecture specific defines should be avoided #124: FILE: linux-user/syscall.c:6967: +#if defined(__NR_futex) WARNING: line over 80 characters #171: FILE: linux-user/syscall.c:7030: +static int do_futex_time64(target_ulong uaddr, int op, int val, target_ulong timeout, WARNING: Block comments use a leading /* on a separate line #177: FILE: linux-user/syscall.c:7036: + /* ??? We assume FUTEX_* constants are the same on both host WARNING: Block comments use * on subsequent lines #178: FILE: linux-user/syscall.c:7037: + /* ??? We assume FUTEX_* constants are the same on both host + and target. */ WARNING: Block comments use a trailing */ on a separate line #178: FILE: linux-user/syscall.c:7037: + and target. */ WARNING: Block comments use a leading /* on a separate line #202: FILE: linux-user/syscall.c:7061: + /* For FUTEX_REQUEUE, FUTEX_CMP_REQUEUE, and FUTEX_WAKE_OP, the WARNING: Block comments use * on subsequent lines #203: FILE: linux-user/syscall.c:7062: + /* For FUTEX_REQUEUE, FUTEX_CMP_REQUEUE, and FUTEX_WAKE_OP, the + TIMEOUT parameter is interpreted as a uint32_t by the kernel. WARNING: Block comments use a trailing */ on a separate line #206: FILE: linux-user/syscall.c:7065: + since it's not compared to guest memory. */ total: 24 errors, 19 warnings, 212 lines checked Patch 12/38 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 13/38 Checking commit c4be83414339 (linux-user/riscv: Update the syscall_nr's to the 5.5 kernel) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #14: new file mode 100644 total: 0 errors, 1 warnings, 898 lines checked Patch 13/38 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/38 Checking commit b3d6a3dcfe70 (linux-user: introduce parameters to generate syscall_nr.h) 15/38 Checking commit baeb698b9306 (linux-user, alpha: add syscall table generation support) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #49: new file mode 100644 total: 0 errors, 1 warnings, 536 lines checked Patch 15/38 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/38 Checking commit 52d7b45efd03 (linux-user, hppa: add syscall table generation support) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #48: new file mode 100644 total: 0 errors, 1 warnings, 491 lines checked Patch 16/38 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/38 Checking commit 9764b87461da (linux-user, m68k: add syscall table generation support) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #47: new file mode 100644 total: 0 errors, 1 warnings, 493 lines checked Patch 17/38 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 18/38 Checking commit 2599c73b5bdb (linux-user, xtensa: add syscall table generation support) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #47: new file mode 100644 total: 0 errors, 1 warnings, 464 lines checked Patch 18/38 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 19/38 Checking commit ea958add11f3 (linux-user, sh4: add syscall table generation support) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #48: new file mode 100644 total: 0 errors, 1 warnings, 497 lines checked Patch 19/38 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 20/38 Checking commit 13a5cddfae33 (linux-user, microblaze: add syscall table generation support) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #49: new file mode 100644 total: 0 errors, 1 warnings, 501 lines checked Patch 20/38 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 21/38 Checking commit 48126a917e3d (linux-user, arm: add syscall table generation support) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #62: new file mode 100644 total: 0 errors, 1 warnings, 531 lines checked Patch 21/38 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 22/38 Checking commit 0a1acf77ecde (linux-user, ppc: add syscall table generation support) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #74: new file mode 100644 total: 0 errors, 1 warnings, 608 lines checked Patch 22/38 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 23/38 Checking commit 07108d6e6087 (linux-user, s390x: remove syscall definitions for !TARGET_S390X) 24/38 Checking commit e7dfa49f0460 (linux-user, s390x: add syscall table generation support) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #49: new file mode 100644 total: 0 errors, 1 warnings, 498 lines checked Patch 24/38 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 25/38 Checking commit 9da00a843cbf (linux-user, sparc, sparc64: add syscall table generation support) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #60: new file mode 100644 total: 0 errors, 1 warnings, 1072 lines checked Patch 25/38 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 26/38 Checking commit 9db49bea0808 (linux-user, x86_64, i386: cleanup TARGET_NR_arch_prctl) 27/38 Checking commit 353fb76ec26f (linux-user, i386: add syscall table generation support) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #50: new file mode 100644 total: 0 errors, 1 warnings, 497 lines checked Patch 27/38 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 28/38 Checking commit 890ff9d1b11d (linux-user, x86_64: add syscall table generation support) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #48: new file mode 100644 total: 0 errors, 1 warnings, 455 lines checked Patch 28/38 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 29/38 Checking commit cd6dd35e397a (linux-user, mips: add syscall table generation support) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #53: new file mode 100644 total: 0 errors, 1 warnings, 488 lines checked Patch 29/38 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 30/38 Checking commit 39929e8aeb2c (linux-user, mips64: add syscall table generation support) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #61: new file mode 100644 total: 0 errors, 1 warnings, 802 lines checked Patch 30/38 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 31/38 Checking commit fdd68d1d7569 (linux-user, scripts: add a script to update syscall.tbl) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #30: new file mode 100755 total: 0 errors, 1 warnings, 56 lines checked Patch 31/38 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 32/38 Checking commit 329d3cf038c3 (linux-user: update syscall.tbl from linux 0bf999f9c5e7) 33/38 Checking commit 6093ee87e3ba (linux-user,mips: move content of mips_syscall_args) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #470: new file mode 100644 total: 0 errors, 1 warnings, 886 lines checked Patch 33/38 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 34/38 Checking commit ba74d13404a4 (linux-user,mips: update syscall-args-o32.c.inc) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #908: new file mode 100755 total: 0 errors, 1 warnings, 938 lines checked Patch 34/38 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 35/38 Checking commit 0f61c4904ada (scripts: add a script to generate syscall_nr.h) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #30: new file mode 100755 total: 0 errors, 1 warnings, 109 lines checked Patch 35/38 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 36/38 Checking commit 6a5d29c054a4 (linux-user, aarch64: sync syscall numbers with kernel v5.5) 37/38 Checking commit fd2f311991d3 (linux-user, nios2: sync syscall numbers with kernel v5.5) 38/38 Checking commit fee33bdd3665 (linux-user, openrisc: sync syscall numbers with kernel v5.5) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200316161550.336150-1-laur...@vivier.eu/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com