Hi Nengyuan, On 2020/3/18 15:22, Pan Nengyuan wrote: > Correcting zhang hailiang's email. > > On 3/18/2020 3:16 PM, Pan Nengyuan wrote: >> This fix coverity issues 94417686: >> 1260 break; >> CID 94417686: (MISSING_BREAK) >> 1261. unterminated_case: The case for value >> "MIGRATION_PARAMETER_THROTTLE_TRIGGER_THRESHOLD" is not terminated by a >> 'break' statement. >> 1261 case MIGRATION_PARAMETER_THROTTLE_TRIGGER_THRESHOLD: >> 1262 p->has_throttle_trigger_threshold = true; >> 1263 visit_type_int(v, param, &p->throttle_trigger_threshold, >> &err); >> 1264 case MIGRATION_PARAMETER_CPU_THROTTLE_INITIAL: >> >> Fixes: dc14a470763c96fd9d360e1028ce38e8c3613a77 >> Reported-by: Euler Robot <euler.ro...@huawei.com> >> Signed-off-by: Pan Nengyuan <pannengy...@huawei.com> >> --- >> Cc: zhukeqi...@huawei.com >> --- >> monitor/hmp-cmds.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c >> index 58724031ea..c882c9f3cc 100644 >> --- a/monitor/hmp-cmds.c >> +++ b/monitor/hmp-cmds.c >> @@ -1261,6 +1261,7 @@ void hmp_migrate_set_parameter(Monitor *mon, const >> QDict *qdict) >> case MIGRATION_PARAMETER_THROTTLE_TRIGGER_THRESHOLD: >> p->has_throttle_trigger_threshold = true; >> visit_type_int(v, param, &p->throttle_trigger_threshold, &err); >> + break; Good fix :). >> case MIGRATION_PARAMETER_CPU_THROTTLE_INITIAL: >> p->has_cpu_throttle_initial = true; >> visit_type_int(v, param, &p->cpu_throttle_initial, &err); >> > > . > Reviewed-by: Keqian Zhu <zhukeqi...@huawei.com>
Thanks, Keqian
