* Philippe Mathieu-Daudé (phi...@redhat.com) wrote: > When using max-bandwidth=~100Mb/s, this test fails on Travis-CI > s390x when configured with --disable-tcg: > > $ make check-qtest > TEST check-qtest-s390x: tests/qtest/boot-serial-test > qemu-system-s390x: -accel tcg: invalid accelerator tcg > qemu-system-s390x: falling back to KVM > TEST check-qtest-s390x: tests/qtest/pxe-test > TEST check-qtest-s390x: tests/qtest/test-netfilter > TEST check-qtest-s390x: tests/qtest/test-filter-mirror > TEST check-qtest-s390x: tests/qtest/test-filter-redirector > TEST check-qtest-s390x: tests/qtest/drive_del-test > TEST check-qtest-s390x: tests/qtest/device-plug-test > TEST check-qtest-s390x: tests/qtest/virtio-ccw-test > TEST check-qtest-s390x: tests/qtest/cpu-plug-test > TEST check-qtest-s390x: tests/qtest/migration-test > ** > ERROR:tests/qtest/migration-test.c:1229:test_migrate_auto_converge: > 'got_stop' should be FALSE > ERROR - Bail out! > ERROR:tests/qtest/migration-test.c:1229:test_migrate_auto_converge: > 'got_stop' should be FALSE > make: *** [tests/Makefile.include:633: check-qtest-s390x] Error 1 > > Per David Gilbert, "it could just be the writing is slow on s390 > and the migration thread fast; in which case the autocomplete > wouldn't be needed. Perhaps we just need to reduce the bandwidth > limit." > > Tuning the threshold by reducing the initial bandwidth makes the > autoconverge test pass. > > Suggested-by: Dr. David Alan Gilbert <dgilb...@redhat.com> > Signed-off-by: Philippe Mathieu-Daudé <phi...@redhat.com> > --- > tests/qtest/migration-test.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c > index 3d6cc83b88..727a97cf87 100644 > --- a/tests/qtest/migration-test.c > +++ b/tests/qtest/migration-test.c > @@ -1211,7 +1211,7 @@ static void test_migrate_auto_converge(void) > * without throttling. > */ > migrate_set_parameter_int(from, "downtime-limit", 1); > - migrate_set_parameter_int(from, "max-bandwidth", 100000000); /* ~100Mb/s > */ > + migrate_set_parameter_int(from, "max-bandwidth", 10000000000); /* > ~10Gb/s */
Hmm - I was expecting you to need to *reduce* the speed; now I'm very confused. You should get 'stop' if the migration completed too soon - surely incresing the bandwidth would make that *more* likely to happen. Dave > /* To check remaining size after precopy */ > migrate_set_capability(from, "pause-before-switchover", true); > -- > 2.21.1 > -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
