> I think we should first introduce a linux-user/generic/termbits.h as we > have an asm-generic/termbits.h in the kernel and use it with all the > targets except alpha, mips, hppa, sparc and xtensa. > > I think this linux-user/generic/termbits.h could be copied from > linux-user/openrisc/termbits.h (without the ioctl definitions) > > Then you could update the remaining ones. >
I agree with you, Laurent, that would be the cleanest implementation. However, I think it requires at least several days of meticulous dev work, that I can't afford at this moment. May I ask you to accept this series as is for 5.0, as a sort of bridge towards the implementation you described? It certainly fixes a majority of termbits-related bugs, many of them remained latent just by fact that XXX and TARGET_XXX were identical. The most affected targets, xtensa, mips and alpha should be cleaned up by this series wrt termbits, and for great majority of issues are cleaned up for all platforms. I just don't have enough time resources to additionally devote to this problem. Sincerely, Aleksandar > Thanks, > Laurent >
