Gentle ping.
Any other suggestions about this?
Thanks.
>-----Original Message-----
>From: Chenqun (kuhn)
>Sent: Wednesday, March 11, 2020 11:29 AM
>To: qemu-devel@nongnu.org; qemu-triv...@nongnu.org
>Cc: Zhanghailiang <zhang.zhanghaili...@huawei.com>; Chenqun (kuhn)
><kuhn.chen...@huawei.com>; Euler Robot <euler.ro...@huawei.com>;
>Kevin Wolf <kw...@redhat.com>; Ronnie Sahlberg
><ronniesahlb...@gmail.com>; Paolo Bonzini <pbonz...@redhat.com>; Peter
>Lieven <p...@kamp.de>; Max Reitz <mre...@redhat.com>; Laurent Vivier
><laur...@vivier.eu>
>Subject: [PATCH v3] block/iscsi:use the flags in iscsi_open() prevent Clang
>warning
>
>Clang static code analyzer show warning:
> block/iscsi.c:1920:9: warning: Value stored to 'flags' is never read
> flags &= ~BDRV_O_RDWR;
> ^ ~~~~~~~~~~~~
>
>In iscsi_allocmap_init() only checks BDRV_O_NOCACHE, which is the same in
>both of flags and bs->open_flags.
>We can use the flags instead bs->open_flags to prevent Clang warning.
>
>Reported-by: Euler Robot <euler.ro...@huawei.com>
>Signed-off-by: Chen Qun <kuhn.chen...@huawei.com>
>Reviewed-by: Kevin Wolf <kw...@redhat.com>
>---
>Cc: Ronnie Sahlberg <ronniesahlb...@gmail.com>
>Cc: Paolo Bonzini <pbonz...@redhat.com>
>Cc: Peter Lieven <p...@kamp.de>
>Cc: Kevin Wolf <kw...@redhat.com>
>Cc: Max Reitz <mre...@redhat.com>
>Cc: Laurent Vivier <laur...@vivier.eu>
>
>v1->v2:
> Keep the 'flags' then use it(Base on Kevin's comments).
>
>v2->v3:
> Modify subject and commit messages(Base on Kevin's and Laurent's
>comments).
>---
> block/iscsi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/block/iscsi.c b/block/iscsi.c index 682abd8e09..50bae51700 100644
>--- a/block/iscsi.c
>+++ b/block/iscsi.c
>@@ -2002,7 +2002,7 @@ static int iscsi_open(BlockDriverState *bs, QDict
>*options, int flags,
> iscsilun->cluster_size = iscsilun->bl.opt_unmap_gran *
> iscsilun->block_size;
> if (iscsilun->lbprz) {
>- ret = iscsi_allocmap_init(iscsilun, bs->open_flags);
>+ ret = iscsi_allocmap_init(iscsilun, flags);
> }
> }
>
>--
>2.23.0
>
