On Thu, Mar 19, 2020 at 06:34:40PM +0100, Paolo Bonzini wrote: > On 19/03/20 14:40, Gerd Hoffmann wrote: > >> Also, can you confirm that it builds without CONFIG_I440FX and > >> CONFIG_Q35? You probably need to add "imply ACPI" and possibly some > >> '#include "config-devices.h"' and '#ifdef CONFIG_ACPI' here and there. > > Hmm, is there some way to do this without modifying > > default-configs/i386-softmmu.mak in the source tree? So I can have two > > build trees with different confugurations? Also to reduce the risk that > > I commit default-config changes by mistake? > > No, there is no way yet.
Hmm, seems we should have that for better regression testing. master branch doesn't build with pc+q35+isapc turned off: LINK x86_64-softmmu/qemu-system-x86_64 hw/virtio/virtio-iommu.o: In function `virtio_iommu_get_bdf': /home/kraxel/projects/qemu/hw/virtio/virtio-iommu.c:66: undefined reference to `pci_bus_num' hw/virtio/virtio-iommu.o: In function `iommu_find_iommu_pcibus': /home/kraxel/projects/qemu/hw/virtio/virtio-iommu.c:84: undefined reference to `pci_bus_num' hw/virtio/virtio-iommu.o: In function `virtio_iommu_device_realize': /home/kraxel/projects/qemu/hw/virtio/virtio-iommu.c:685: undefined reference to `pci_setup_iommu' collect2: error: ld returned 1 exit status [ adding Eric Auger to Cc: ] cheers, Gerd
