On 20/03/20 13:56, Dr. David Alan Gilbert wrote: >> According to https://wiki.qemu.org/ToDo/LockGuards cases that are trivial (no >> conditional logic) shouldn't be replaced. > OK
I don't think that has to be either-or. Trivial lock/unlock sequences are not the first ones that should be converted, but there's an advantage in having a single patch that converts all possible uses of a lock. Trivial sequences certainly do not belong in a bigger patch like this, as they would make the patch even bigger. > So for what you've already got there, > > For migration: > Acked-by: Dr. David Alan Gilbert <dgilb...@redhat.com> > Can you just extract that and queue it yourself (for 5.1 probably)? Paolo