On Sat, Mar 21, 2020 at 7:45 AM Philippe Mathieu-Daudé <phi...@redhat.com> wrote: > > Fix warning reported by Clang static code analyzer: > > CC hw/i2c/pm_smbus.o > hw/i2c/pm_smbus.c:187:17: warning: Value stored to 'ret' is never read > ret = 0; > ^ ~ > > Reported-by: Clang Static Analyzer > Signed-off-by: Philippe Mathieu-Daudé <phi...@redhat.com>
Reviewed-by: Alistair Francis <alistair.fran...@wdc.com> Alistair > --- > hw/i2c/pm_smbus.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/hw/i2c/pm_smbus.c b/hw/i2c/pm_smbus.c > index 36994ff585..4728540c37 100644 > --- a/hw/i2c/pm_smbus.c > +++ b/hw/i2c/pm_smbus.c > @@ -184,7 +184,6 @@ static void smb_transaction(PMSMBus *s) > s->smb_stat |= STS_HOST_BUSY | STS_BYTE_DONE; > s->smb_data[0] = s->smb_blkdata; > s->smb_index = 0; > - ret = 0; > } > goto out; > } > -- > 2.21.1 > >
