On 3/25/20 7:47 PM, Marc-André Lureau wrote:
If object-add failed, no need to create a return value that may later be leaked.Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> --- qom/qom-qmp-cmds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qom/qom-qmp-cmds.c b/qom/qom-qmp-cmds.c index 435193b036..6bd137ccbf 100644 --- a/qom/qom-qmp-cmds.c +++ b/qom/qom-qmp-cmds.c @@ -287,8 +287,8 @@ void qmp_object_add(QDict *qdict, QObject **ret_data, Error **errp) visit_free(v); if (obj) { object_unref(obj); + *ret_data = QOBJECT(qdict_new()); } - *ret_data = QOBJECT(qdict_new()); }void qmp_object_del(const char *id, Error **errp)
Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com>
