On Wed, 25 Mar 2020 at 19:19, Philippe Mathieu-Daudé <f4...@amsat.org> wrote: > > Running the coccinelle script produced: > > $ spatch \ > --macro-file scripts/cocci-macro-file.h --include-headers \ > --sp-file > scripts/coccinelle/object_property_missing_error_propagate.cocci \ > --keep-comments --smpl-spacing --dir hw > > [[manual check required: error_propagate() might be missing in > object_property_set_int() hw/mips/mips_malta.c:1193:4]] > [[manual check required: error_propagate() might be missing in > object_property_set_str() hw/mips/mips_malta.c:1192:4]] > > Add the missing error_propagate() after manual review by adding > a Error* parameter to create_cps(). > > Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> > --- > hw/mips/mips_malta.c | 19 ++++++++++++++----- > 1 file changed, 14 insertions(+), 5 deletions(-)
Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> thanks -- PMM
