On Tue, 31 Mar 2020 at 10:01, Markus Armbruster <arm...@redhat.com> wrote: > I doubt including basic spatch instructions with every script is a good > idea. Better explain it in one place, with proper maintenance. > scripts/coccinelle/README? We could be a bit more verbose there, > e.g. to clarify required vs. suggested options.
I find it useful -- you (hopefully) get the actual command line the original author used, rather than having to guess which options might be significant. (eg the last one I added uses --keep-comments --smpl-spacing --include-headers --dir target which aren't all always used but which do all matter here for getting the change that went in in the commit that used the script.) Most of us use coccinelle as an occasional tool, not an everyday one, so not having to look through the docs to figure out the right rune is a benefit, even for the options that we do use on pretty much every spatch run. thanks -- PMM
