On 4 July 2011 19:52, Stefan Weil <w...@mail.berlios.de> wrote: > Some versions of png.h cannot be included after setjmp.h, > even when PNG_SKIP_SETJMP_CHECK was defined. > > setjmp.h was included from qemu-common.h and is not needed there. > Removing the include statement fixes compilation of ui/vnc-enc-tight.c > with CONFIG_VNC_PNG defined.
This isn't the only unnecessary include of setjmp.h, incidentally. The includes in target-alpha/cpu.h and target-ppc/cpu.h could also be removed (cpu-defs.h includes setjmp.h). That would also make those targets consistent with all the rest (which don't include setjmp), so it seems worth the minor cleanup. I'll send a patch... -- PMM
