20:08 Sub, 11.04.2020. Richard Henderson <richard.hender...@linaro.org> је написао/ла: > > On 4/11/20 5:46 AM, lixinyu wrote: > > OPC_SYNC_WMB, OPC_SYNC_MB, OPC_SYNC_ACQUIRE, OPC_SYNC_RELEASE and > > OPC_SYNC_RMB have wrong encode. According to the mips manual, > > their encode should be 'OPC_SYNC | 0x?? << 6' rather than > > 'OPC_SYNC | 0x?? << 5'. Wrong encode can lead illegal instruction > > errors. These instructions often appear with multi-threaded > > simulation. > > Good catch. > > Reviewed-by: Richard Henderson <richard.hender...@linaro.org> > > Queued to tcg-for-5.0. >
Reviewed-by: Aleksandar Markovic <aleksandar.qemu.de...@gmail.com> Thanks to Lixinyu, in the first place, for reporting the problem, and also thanks to Richard for reviewing and incorporating this patch into his queue for 5.0. I also think, as Richard does, that this should go into 5.0, even in this final stages. Happy Easter, or hapy and sunny weekend, whatever you choose. Aleksandar > > r~ >
