On Sun, Apr 12, 2020 at 3:58 PM Philippe Mathieu-Daudé <f4...@amsat.org> wrote: > > Patch created mechanically by running: > > $ spatch \ > --macro-file scripts/cocci-macro-file.h --include-headers \ > --sp-file scripts/coccinelle/use-error_propagate-in-realize.cocci \ > --keep-comments --smpl-spacing --in-place --dir hw > > Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org>
Reviewed-by: Alistair Francis <alistair.fran...@wdc.com> Alistair > --- > hw/microblaze/xlnx-zynqmp-pmu.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/hw/microblaze/xlnx-zynqmp-pmu.c b/hw/microblaze/xlnx-zynqmp-pmu.c > index 2aa602cf85..4ecbea7fdc 100644 > --- a/hw/microblaze/xlnx-zynqmp-pmu.c > +++ b/hw/microblaze/xlnx-zynqmp-pmu.c > @@ -123,7 +123,11 @@ static void xlnx_zynqmp_pmu_soc_realize(DeviceState > *dev, Error **errp) > /* Connect the IPI device */ > for (int i = 0; i < XLNX_ZYNQMP_PMU_NUM_IPIS; i++) { > object_property_set_bool(OBJECT(&s->ipi[i]), true, "realized", > - &error_abort); > + &err); > + if (err) { > + error_propagate(errp, err); > + return; > + } > sysbus_mmio_map(SYS_BUS_DEVICE(&s->ipi[i]), 0, ipi_addr[i]); > sysbus_connect_irq(SYS_BUS_DEVICE(&s->ipi[i]), 0, > qdev_get_gpio_in(DEVICE(&s->intc), ipi_irq[i])); > -- > 2.21.1 > >