Eric Blake <ebl...@redhat.com> writes: > On 4/9/20 12:09 PM, no-re...@patchew.org wrote: >> Patchew URL: >> https://patchew.org/QEMU/20200409153041.17576-1-arm...@redhat.com/ >> >> >> >> Hi, >> >> This series seems to have some coding style problems. See output below for >> more information: >> > >> === OUTPUT BEGIN === >> 1/8 Checking commit 2e003109273b (tests-qemu-opts: Cover has_help_option(), >> qemu_opt_has_help_opt()) >> WARNING: Block comments use a leading /* on a separate line >> #37: FILE: tests/test-qemu-opts.c:747: >> + { "a,b,,help", false /* BUG */, true, true }, > > Annoying, but I don't mind ignoring it (especially since we fix the > bug later in the series). > >> >> total: 0 errors, 1 warnings, 50 lines checked >> >> Patch 1/8 has style problems, please review. If any of these errors >> are false positives report them to the maintainer, see >> CHECKPATCH in MAINTAINERS. >> 2/8 Checking commit 8bb805dd3730 (qemu-options: Factor out >> get_opt_name_value() helper) >> 3/8 Checking commit b3630a346906 (qemu-option: Fix sloppy recognition of >> "id=..." after ", , ") >> 4/8 Checking commit 5c1b2db0b7ad (qemu-option: Avoid has_help_option() in >> qemu_opts_parse_noisily()) >> 5/8 Checking commit 6845c29bee11 (qemu-option: Fix has_help_option()'s >> sloppy parsing) >> 6/8 Checking commit b7fcaaeeeb6f (test-qemu-opts: Simplify >> test_has_help_option() after bug fix) >> 7/8 Checking commit b164930d4c8d (qemu-img: Factor out accumulate_options() >> helper) >> 8/8 Checking commit 505f5f389855 (qemu-option: Move is_valid_option_list() >> to qemu-img.c and rewrite) >> ERROR: suspect code indent for conditional statements (4, 4) >> #61: FILE: qemu-img.c:243: >> + for (i = len; i > 0 && optarg[i - 1] == ','; i--) { >> + } > > False positive. Maybe you can shut up the checker by: > for (...) { > /* nothing further to do */ > }
I don't like to add code to work around checkpatch bugs. Rare checkpatch bugs can be ignored, non-rare ones should be fixed.
