From: Marian Rotariu <marian.c.rota...@gmail.com> On forced reset, KVM and the instrospection tool must clean-up the introspection structures. An important thing that must by done by KVM is to unlink the shared memory pages (the introspection tool can map memory pages from the introspected VM in its own process/VM).
CC: Markus Armbruster <arm...@redhat.com> Signed-off-by: Marian Rotariu <marian.c.rota...@gmail.com> Signed-off-by: Adalbert Lazăr <ala...@bitdefender.com> --- accel/kvm/vmi.c | 6 ++++++ include/sysemu/vmi-intercept.h | 2 ++ monitor/qmp-cmds.c | 4 ++++ 3 files changed, 12 insertions(+) diff --git a/accel/kvm/vmi.c b/accel/kvm/vmi.c index e511558f3d..90906478b4 100644 --- a/accel/kvm/vmi.c +++ b/accel/kvm/vmi.c @@ -73,6 +73,7 @@ static const char *action_string[] = { "none", "suspend", "resume", + "force-reset", }; static bool suspend_pending; @@ -677,6 +678,8 @@ static bool record_intercept_action(VMI_intercept_command action) case VMI_INTERCEPT_RESUME: suspend_pending = false; break; + case VMI_INTERCEPT_FORCE_RESET: + break; default: return false; } @@ -693,6 +696,9 @@ static bool intercept_action(VMIntrospection *i, } switch (action) { + case VMI_INTERCEPT_FORCE_RESET: + disconnect_and_unhook_kvmi(i); + return false; case VMI_INTERCEPT_RESUME: enable_socket_reconnect(i); return false; diff --git a/include/sysemu/vmi-intercept.h b/include/sysemu/vmi-intercept.h index 06998ff18a..ef591b49e7 100644 --- a/include/sysemu/vmi-intercept.h +++ b/include/sysemu/vmi-intercept.h @@ -14,8 +14,10 @@ typedef enum { VMI_INTERCEPT_NONE = 0, VMI_INTERCEPT_SUSPEND, VMI_INTERCEPT_RESUME, + VMI_INTERCEPT_FORCE_RESET, } VMI_intercept_command; bool vm_introspection_intercept(VMI_intercept_command ic, Error **errp); +bool vm_introspection_qmp_delay(void *mon, QObject *id, bool resume); #endif /* QEMU_VMI_INTERCEPT_H */ diff --git a/monitor/qmp-cmds.c b/monitor/qmp-cmds.c index eabd20fca3..d164635b5f 100644 --- a/monitor/qmp-cmds.c +++ b/monitor/qmp-cmds.c @@ -98,6 +98,10 @@ void qmp_stop(Error **errp) void qmp_system_reset(Error **errp) { + if (vm_introspection_intercept(VMI_INTERCEPT_FORCE_RESET, errp)) { + return; + } + qemu_system_reset_request(SHUTDOWN_CAUSE_HOST_QMP_SYSTEM_RESET); }