On 4/16/20 9:30 AM, Philippe Mathieu-Daudé wrote:
On 4/16/20 5:47 PM, Peter Maydell wrote:
On Thu, 16 Apr 2020 at 16:45, Peter Maydell <peter.mayd...@linaro.org> wrote:
On Sun, 29 Mar 2020 at 00:18, Paul Zimmerman <pauld...@gmail.com> wrote:
+ s->as = &address_space_memory;
Ideally this should be a device property. (hw/dma/pl080.c
has an example of how to declare a TYPE_MEMORY_REGION
property and then create an AddressSpace from it in
the realize method. hw/arm/versatilepb.c and hw/arm/mps2-tz.c
show the other end, using object_property_set_link() to pass
the appropriate MemoryRegion to the device before realizing it.)
On closer inspection you're already doing that with the dma_as/
dma_mr. What's this AddressSpace for if it's different?
s->as is not used, probably a leftover (s->dma_as is used).
thanks
-- PMM
Thanks for the reviews guys, I will take all your suggestions into
account before I post the next series.
Thanks,
Paul
