Re: [PATCH 3/4] bamboo, sam460ex: Tidy up error message for unsupported RAM size

[Philippe Mathieu-Daudé]

On 4/20/20 3:28 PM, Markus Armbruster wrote:

Improve

     $ ppc-softmmu/qemu-system-ppc -M sam460ex -m 4096
     qemu-system-ppc: Max 1 banks of 2048 ,1024 ,512 ,256 ,128 ,64 ,32 MB 
DIMM/bank supported
     qemu-system-ppc: Possible valid RAM size: 2048

to

     qemu-system-ppc: Max 1 banks of 2048, 1024, 512, 256, 128, 64, 32 MB 
DIMM/bank supported
     Possible valid RAM size: 2048

Signed-off-by: Markus Armbruster <arm...@redhat.com>
---
  hw/ppc/ppc4xx_devs.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/ppc/ppc4xx_devs.c b/hw/ppc/ppc4xx_devs.c
index 3376c43ff5..dea39546ad 100644
--- a/hw/ppc/ppc4xx_devs.c
+++ b/hw/ppc/ppc4xx_devs.c
@@ -716,11 +716,11 @@ void ppc4xx_sdram_banks(MemoryRegion *ram, int nr_banks,
          for (i = 0; sdram_bank_sizes[i]; i++) {
              g_string_append_printf(s, "%" PRIi64 "%s",
                                     sdram_bank_sizes[i] / MiB,
-                                   sdram_bank_sizes[i + 1] ? " ," : "");
+                                   sdram_bank_sizes[i + 1] ? ", " : "");
          }
          error_report("Max %d banks of %s MB DIMM/bank supported",
              nr_banks, s->str);
-        error_report("Possible valid RAM size: %" PRIi64,
+        error_printf("Possible valid RAM size: %" PRIi64 "\n",

Maybe nicer:

           error_printf("Possible valid RAM size: %" PRIi64 " MB\n",

Regardless
Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com>

              used_size ? used_size / MiB : sdram_bank_sizes[i - 1] / MiB);

g_string_free(s, true);