On Thu, Apr 23, 2020 at 08:52:58AM -0400, Michael S. Tsirkin wrote: > On Wed, Apr 22, 2020 at 11:54:54PM +0200, Anthoine Bourgeois wrote: > > With virtio-vga, pci bar are reordered. Bar #2 is used for compatibility > > with stdvga. By default, bar #2 is used by virtio modern io bar. > > This bar is the last one introduce in the virtio pci bar layout and it's > > crushed by the virtio-vga reordering. So virtio-vga and > > modern-pio-notify are incompatible because virtio-vga failed to > > initialize with this option. > > > > This fix sets the modern io bar to the bar #5 to avoid conflict. > > > > Signed-off-by: Anthoine Bourgeois <anthoine.bourge...@gmail.com> > > Gerd, would you say it's required for 5.0?
Given that modern-pio-notify is off by default I wouldn't classify this as release blocker, i.e. I wouldn't delay the release for that. We are at -rc4 (last rc) already, so I'd tend to say no. Maybe if we need -rc5 for other reasons. cheers, Gerd
