On Wed 22 Apr 2020 02:38:54 PM CEST, Vladimir Sementsov-Ogievskiy wrote: > 17.03.2020 21:16, Alberto Garcia wrote: >> l2meta_cow_start() and l2meta_cow_end() are not necessarily >> cluster-aligned if the image has subclusters, so update the >> calculation of old_start and old_end to guarantee that no two requests >> try to write on the same cluster. >> >> Signed-off-by: Alberto Garcia <be...@igalia.com> >> Reviewed-by: Max Reitz <mre...@redhat.com> > > Somehow, this patch say me "hey, there may be a lot of other small > places, which we forget to fix about subclusters, and you have no > idea, how to find and check them all" :) Probably the only way is > reviewing the whole qcow2 code, but it's too huge task.. [this is just > thinking out loud]
:-) > Actually, you call it "Fix", and it seems to be a fix for your "[PATCH > v4 17/30] qcow2: Add subcluster support to > calculate_l2_meta()". Shouldn't it be squashed in? Maybe it't not a bad idea... I'll have a look. Berto