On 24.04.20 11:56, Max Reitz wrote: > On 24.04.20 11:53, Max Reitz wrote: >> On 24.04.20 00:17, Eric Blake wrote: >>> There are several callers that need to create a new block backend from >>> an existing BDS; make the task slightly easier with a common helper >>> routine. >>> >>> Suggested-by: Max Reitz <mre...@redhat.com> >>> Signed-off-by: Eric Blake <ebl...@redhat.com> >>> --- >>> include/sysemu/block-backend.h | 2 ++ >>> block/block-backend.c | 23 +++++++++++++++++++++++ >>> block/crypto.c | 8 +++----- >>> block/parallels.c | 7 +++---- >>> block/qcow.c | 7 +++---- >>> block/qcow2.c | 15 ++++++--------- >>> block/qed.c | 7 +++---- >>> block/sheepdog.c | 9 ++++----- >>> block/vdi.c | 7 +++---- >>> block/vhdx.c | 7 +++---- >>> block/vmdk.c | 9 ++++----- >>> block/vpc.c | 7 +++---- >>> blockdev.c | 8 +++----- >>> blockjob.c | 7 ++----- >>> 14 files changed, 65 insertions(+), 58 deletions(-) >> >> Reviewed-by: Max Reitz <mre...@redhat.com> > > (With the Patchew warning fixed, of course (i.e., we should set ret to > -EPERM or something in qcow.c))
Er, well, maybe I should have looked into more places. The compiler only warns about that single one because it’s the only place where @ret is really uninitialized, but there are many more where we need to set it: crypto.c, parallels.c, qcow.c, qcow2.c (both hunks), qed.c, sheepdog.c, vdi.c, vhdx.c, and vpc.c. (So basically everywhere but vmdk.c, blockdev.c, and blockjob.c.) And now I’m going to get another coffee... Max
signature.asc
Description: OpenPGP digital signature