Patchew URL: https://patchew.org/QEMU/20200429200754.18327-1-alex.ben...@linaro.org/
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200429200754.18327-1-alex.ben...@linaro.org Subject: [RFC PATCH v2] plugins: new lockstep plugin for debugging TCG changes Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Switched to a new branch 'test' 0f98ef2 plugins: new lockstep plugin for debugging TCG changes === OUTPUT BEGIN === WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #54: new file mode 100644 WARNING: line over 80 characters #175: FILE: tests/plugin/lockstep.c:117: + g_string_append_printf(out, "We are @ %#016lx vs %#016lx\n", us->pc, them->pc); WARNING: line over 80 characters #179: FILE: tests/plugin/lockstep.c:121: + g_string_append_printf(out, " previously @ %#016lx/%ld (%ld insn, %ld blocks)\n", ERROR: do not use C99 // comments #259: FILE: tests/plugin/lockstep.c:201: + // save a reference so we can free later total: 1 errors, 3 warnings, 322 lines checked Commit 0f98ef2b5ce2 (plugins: new lockstep plugin for debugging TCG changes) has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200429200754.18327-1-alex.ben...@linaro.org/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
