On Mon, 27 Apr 2020 at 17:00, Richard Henderson <richard.hender...@linaro.org> wrote: > > On 4/27/20 3:48 AM, Peter Maydell wrote: > > The old code passed size into cc->tlb_fill; the new version does not. > > The old code passed size into page_check_range(); the new version does not. > > This is the user-only version, and size is not used for tlb_fill. It is only > trivially used in page_change_range; we have just verified that addr+size does > not cross a page boundary.
Yes, but: * they're APIs which take sizes * we have the size in hand so it's not difficult to pass it * in future maybe those functions will change to make more use of the size value, since they're being passed it * this change ought to be a refactoring that does the same thing the old code does What's the reason for deliberately *not* passing the size and instead using a constant 1 ? thanks -- PMM
