Patchew URL: https://patchew.org/QEMU/20200505152926.18877-1-arm...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20200505152926.18877-1-arm...@redhat.com
Subject: [PATCH v2 00/18] qom: Spring cleaning
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
0bfeda6 qom: Drop @errp parameter of object_property_del()
fce53a6 spapr_pci: Drop some dead error handling
bf4fa1d qdev: Unrealize must not fail
c984f35 Drop more @errp parameters after previous commit
3217176 qom: Drop parameter @errp of object_property_add() & friends
e43f7cf qdev: Clean up qdev_connect_gpio_out_named()
25ed6da hw/arm/bcm2835: Drop futile attempts at QOM-adopting memory
2b01f96 e1000: Don't run e1000_instance_init() twice
0859a4a hw/isa/superio: Make the components QOM children
0ad9369 s390x/cpumodel: Fix UI to CPU features pcc-cmac-{aes, eaes}-256
a7bcd4a tests/check-qom-proplist: Improve iterator coverage
a89bf38 qom: Drop object_property_set_description() parameter @errp
2c9507b qom: Make all the object_property_add_FOO() return the property
caeed6f qom: Drop convenience method object_property_get_uint16List()
670a5b1 qom: Simplify object_property_get_enum()
4e0ef1e qom: Drop object_property_del_child()'s unused parameter @errp
3305770 qom: Clean up inconsistent use of gchar * vs. char *
237690a qom: Clearer reference counting in object_initialize_childv()
=== OUTPUT BEGIN ===
1/18 Checking commit 237690a0fd11 (qom: Clearer reference counting in
object_initialize_childv())
2/18 Checking commit 33057701be2e (qom: Clean up inconsistent use of gchar *
vs. char *)
3/18 Checking commit 4e0ef1e4e32d (qom: Drop object_property_del_child()'s
unused parameter @errp)
4/18 Checking commit 670a5b17a0f5 (qom: Simplify object_property_get_enum())
5/18 Checking commit caeed6fde79c (qom: Drop convenience method
object_property_get_uint16List())
6/18 Checking commit 2c9507b8735b (qom: Make all the object_property_add_FOO()
return the property)
7/18 Checking commit a89bf3817999 (qom: Drop object_property_set_description()
parameter @errp)
8/18 Checking commit a7bcd4a69d42 (tests/check-qom-proplist: Improve iterator
coverage)
9/18 Checking commit 0ad93695c816 (s390x/cpumodel: Fix UI to CPU features
pcc-cmac-{aes, eaes}-256)
ERROR: line over 90 characters
#53: FILE: target/s390x/cpu_features_def.inc.h:314:
+DEF_FEAT(PCC_CMAC_AES_256, "pcc-cmac-aes-256", PCC, 20, "PCC
Compute-Last-Block-CMAC-Using-AES-256")
total: 1 errors, 0 warnings, 8 lines checked
Patch 9/18 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
10/18 Checking commit 0859a4ae84dc (hw/isa/superio: Make the components QOM
children)
11/18 Checking commit 2b01f963380b (e1000: Don't run e1000_instance_init()
twice)
12/18 Checking commit 25ed6da2c511 (hw/arm/bcm2835: Drop futile attempts at
QOM-adopting memory)
13/18 Checking commit e43f7cf1877d (qdev: Clean up
qdev_connect_gpio_out_named())
14/18 Checking commit 321717690e42 (qom: Drop parameter @errp of
object_property_add() & friends)
WARNING: line over 80 characters
#209: FILE: backends/hostmem-file.c:187:
+ file_memory_backend_get_discard_data,
file_memory_backend_set_discard_data);
WARNING: line over 80 characters
#1080: FILE: hw/arm/raspi.c:287:
+ object_property_add_const_link(OBJECT(&s->soc), "ram",
OBJECT(machine->ram));
WARNING: line over 80 characters
#3095: FILE: hw/ppc/spapr.c:3346:
+ &spapr->kernel_addr,
OBJ_PROP_FLAG_READWRITE);
total: 0 errors, 3 warnings, 4471 lines checked
Patch 14/18 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/18 Checking commit c984f35ccd32 (Drop more @errp parameters after previous
commit)
16/18 Checking commit bf4fa1d40108 (qdev: Unrealize must not fail)
17/18 Checking commit fce53a6de430 (spapr_pci: Drop some dead error handling)
18/18 Checking commit 0bfeda6594be (qom: Drop @errp parameter of
object_property_del())
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20200505152926.18877-1-arm...@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com
