On 07/12/2011 01:03 AM, malc wrote:
>
>  Here's a new version:

This one looks acceptable[1], original submission said:
"fixes BAR sizing as well." what was wrong with it?

The nabm BAR, for example, was registered as 64 bytes of byte ioports, 128 bytes of word ioports, and 256 bytes of long ioports. I expect this was an error.

The new patch preserves the error.

[..snip..]

P.S. Sans minor inconsistency with trailing commas.


Where I expect more fields, I leave a trailing comma. It makes further patches nicer.

--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.


Reply via email to