Am 07.05.2020 um 16:29 hat Eric Blake geschrieben: > On 5/7/20 5:15 AM, Kevin Wolf wrote: > > Am 28.04.2020 um 22:28 hat Eric Blake geschrieben: > > > Based-on: <20200424125448.63318-1-kw...@redhat.com> > > > [PATCH v7 00/10] block: Fix resize (extending) of short overlays > > > > > > After reviewing Kevin's work, I questioned if we had a redundancy with > > > bdrv_has_zero_init_truncate. It turns out we do, and this is the result. > > > > > > Patch 1 has been previously posted [1] and reviewed, the rest is new. > > > I did not address Neils' comment that modern gluster also always > > > 0-initializes [2], as I am not set up to verify it (my changes to the > > > other drivers are semantic no-ops, so I don't feel as bad about > > > posting them with less rigourous testing). > > > > > > [1] https://lists.gnu.org/archive/html/qemu-devel/2020-01/msg08070.html > > > [2] https://lists.gnu.org/archive/html/qemu-devel/2020-02/msg04266.html > > > > block/parallels.c: In function 'parallels_co_writev': > > block/parallels.c:218:12: error: 'ret' may be used uninitialized in this > > function [-Werror=maybe-uninitialized] > > 218 | if (ret < 0) { > > | ^ > > block/parallels.c:169:9: note: 'ret' was declared here > > 169 | int ret; > > | ^~~ > > cc1: all warnings being treated as errors > > Yep, fixup posted here: > https://lists.gnu.org/archive/html/qemu-devel/2020-04/msg05199.html > > > > > Apart from that, you can add: > > > > Reviewed-by: Kevin Wolf <kw...@redhat.com> > > Do you need me to send a v2?
Ah, sorry, I missed that you had already sent a fixup. I'll squash it in. Kevin