Hello, On Wed, May 6, 2020 at 8:30 PM Richard Henderson <richard.hender...@linaro.org> wrote: > > In a few cases, we're able to remove some manual replication. > > Reviewed-by: Alex Bennée <alex.ben...@linaro.org> > Signed-off-by: Richard Henderson <richard.hender...@linaro.org> > --- > target/arm/translate-a64.c | 10 +++++----- > target/arm/translate-sve.c | 12 +++++------- > target/arm/translate.c | 9 ++++++--- > 3 files changed, 16 insertions(+), 15 deletions(-) > > diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c > index a896f9c4b8..62e5729904 100644 > --- a/target/arm/translate-a64.c > +++ b/target/arm/translate-a64.c [...] > @@ -2044,7 +2044,7 @@ static bool trans_DUP_x(DisasContext *s, arg_DUP_x *a) > unsigned nofs = vec_reg_offset(s, a->rn, index, esz); > tcg_gen_gvec_dup_mem(esz, dofs, nofs, vsz, vsz); > } else { > - tcg_gen_gvec_dup64i(dofs, vsz, vsz, 0); > + tcg_gen_gvec_dup_imm(esz, dofs, vsz, vsz, 0);
For an indexed DUP, size can be 128-bit so that will fail the first assert in tcg-op-gvec.c:do_dup. Thanks, Laurent