On Fri, 8 May 2020 at 16:44, Richard Henderson <richard.hender...@linaro.org> wrote: > > We have validated that addr+size does not cross a page boundary. > Therefore we need to validate exactly one page. We can achieve > that passing any value 1 <= x <= size to page_check_range. > > Passing 1 will simplify the next patch.
It's not clear to me how it simplifies the next patch, though -- we have the size right there in the new function which calls page_check_range(), don't we? So I still don't understand why we're using '1' -- it isn't allowing us to avoid passing the size into probe_access_internal(), because we need to pass it anyway. We've gone round this multiple times now so I feel like I must be missing something here. thanks -- PMM
